From 282a06753564cfdf6c2b136fff128e7f9ed790d1 Mon Sep 17 00:00:00 2001 From: Aron Roberts Date: Fri, 19 Feb 2010 18:45:18 +0000 Subject: [PATCH] CSPACE-1030: Ensure that Contact common part label is set correctly, when populating sample record for 'create' test in ContactServiceTest. --- .../services/client/ContactClientUtils.java | 15 +++++++++------ .../services/client/test/ContactServiceTest.java | 6 ++++-- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/services/contact/client/src/main/java/org/collectionspace/services/client/ContactClientUtils.java b/services/contact/client/src/main/java/org/collectionspace/services/client/ContactClientUtils.java index 39c851ecb..30c2d3182 100644 --- a/services/contact/client/src/main/java/org/collectionspace/services/client/ContactClientUtils.java +++ b/services/contact/client/src/main/java/org/collectionspace/services/client/ContactClientUtils.java @@ -11,10 +11,11 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; public class ContactClientUtils { + private static final Logger logger = LoggerFactory.getLogger(ContactClientUtils.class); - public static MultipartOutput createContactInstance(String identifier) { + public static MultipartOutput createContactInstance(String identifier, String headerLabel) { String inAuthority = ""; String inItem = ""; return createContactInstance( @@ -22,22 +23,24 @@ public class ContactClientUtils { inItem, "addressText1-" + identifier, "postcode-" + identifier, - "addressType1-" + identifier); + "addressType1-" + identifier, + headerLabel); } public static MultipartOutput createContactInstance( - String inAuthority, String inItem, String identifier) { + String inAuthority, String inItem, String identifier, String headerLabel) { return createContactInstance( inAuthority, inItem, "addressText1-" + identifier, "postcode-" + identifier, - "addressType1-" + identifier); + "addressType1-" + identifier, + headerLabel); } public static MultipartOutput createContactInstance( String inAuthority, String inItem, String addressText, - String postcode, String addressType) { + String postcode, String addressType, String headerLabel) { ContactsCommon contact = new ContactsCommon(); contact.setInAuthority(inAuthority); contact.setInItem(inItem); @@ -48,7 +51,7 @@ public class ContactClientUtils { OutputPart commonPart = multipart.addPart(contact, MediaType.APPLICATION_XML_TYPE); ContactClient client = new ContactClient(); - commonPart.getHeaders().add("label", client.getCommonPartName()); + commonPart.getHeaders().add("label", headerLabel); if(logger.isDebugEnabled()){ logger.debug("to be created, contact common"); diff --git a/services/contact/client/src/test/java/org/collectionspace/services/client/test/ContactServiceTest.java b/services/contact/client/src/test/java/org/collectionspace/services/client/test/ContactServiceTest.java index f36b28122..91b5e6fa2 100644 --- a/services/contact/client/src/test/java/org/collectionspace/services/client/test/ContactServiceTest.java +++ b/services/contact/client/src/test/java/org/collectionspace/services/client/test/ContactServiceTest.java @@ -78,7 +78,8 @@ public class ContactServiceTest extends AbstractServiceTestImpl { // Submit the request to the service and store the response. String identifier = createIdentifier(); - MultipartOutput multipart = ContactClientUtils.createContactInstance(identifier); + MultipartOutput multipart = + ContactClientUtils.createContactInstance(identifier, client.getCommonPartName()); ClientResponse res = client.create(multipart); int statusCode = res.getStatus(); @@ -483,7 +484,8 @@ public class ContactServiceTest extends AbstractServiceTestImpl { // The only relevant ID may be the one used in update(), below. // The only relevant ID may be the one used in update(), below. - MultipartOutput multipart = ContactClientUtils.createContactInstance(NON_EXISTENT_ID); + MultipartOutput multipart = + ContactClientUtils.createContactInstance(NON_EXISTENT_ID, client.getCommonPartName()); ClientResponse res = client.update(NON_EXISTENT_ID, multipart); int statusCode = res.getStatus(); -- 2.47.3