Aron Roberts [Fri, 20 Aug 2010 02:01:35 +0000 (02:01 +0000)]
CSPACE-2671: Multiple changes to CollectionSpace record schema in the services layer, reflecting 1.0 alpha changes specified by the Functional team. Added ten (10) fields, removed two (2) fields, and converted six (6) fields from scalar to repeatable scalar. See comment in issue for list of fields changed. No services tests failed after these changes, however there are no tests currently in place to verify that these fields are working; that work is identified to be carried out in CSPACE-2609.
Aron Roberts [Thu, 19 Aug 2010 23:25:02 +0000 (23:25 +0000)]
CSPACE-2300: Added borrowersAuthorizer field to LoansIn (aka LoansIn) records, in services schema. Constitutes a Nuxeo document type update, and as such requires an 'ant deploy' and a 2-server restart.
Aron Roberts [Thu, 19 Aug 2010 21:11:12 +0000 (21:11 +0000)]
CSPACE-2671: Annotated CollectionObject schema (Nuxeo doctype schema), in the services layer, to reflect the results of a schema change and repeatability review. All fields that will be changed - added, removed, made singly repeatable - are annotated with a '[1.0 alpha]' note; other notes reflect upcoming changes, post-1.0 alpha, to create repeatable groups and the like.
Richard Millet [Thu, 19 Aug 2010 15:54:31 +0000 (15:54 +0000)]
CSPACE-1432: Odd that my SVN client shows these added and checked-in, but apparently not. Original post: Apply "List - pagination (return total items, current page, total pages) " functionality to Account
Richard Millet [Thu, 19 Aug 2010 15:53:12 +0000 (15:53 +0000)]
CSPACE-1432: Odd that my SVN client shows these added and checked-in, but apparently not. Original post: Apply "List - pagination (return total items, current page, total pages) " functionality to Account
Aron Roberts [Wed, 18 Aug 2010 04:12:45 +0000 (04:12 +0000)]
CSPACE-2653: Dates in unrecognized formats, when sent to services as values in date-type fields, now generate error messages, rather than being silently 'dropped' and resulting in null/empty values being stored in those fields. Recognized formats include Nuxeo's supported ISO 8601-based formats, as well as any additional formats configured on a per-tenant basis.
Aron Roberts [Wed, 18 Aug 2010 01:38:25 +0000 (01:38 +0000)]
CSPACE-2418: Services can now accept, as input to date fields in their record types, dates in a variety of representation formats, specified in per-tenant configuration. This will permit free text entry of dates in formats familiar to users in various countries, such as 'MM/dd/yyyy' (USA), 'dd/MM/yyyy' (UK), and 'dd.MM.yyyy' (one of several formats used in Denmark). No validation is yet performed, and dates in unrecognized formats, that cannot be parsed and converted to the ISO 8601-based formats required by Nuxeo and MySQL, are silently dropped, as they were even before this check-in. This is addressed by a new bug, CSPACE-2653.
Aron Roberts [Tue, 17 Aug 2010 02:31:22 +0000 (02:31 +0000)]
CSPACE-2418: Groundwork for supporting free-text entry of dates in a variety of formats. Added utility routines to retrieve per-tenant lists of properties, and demonstrated retrieval of date formats from those properties, and of validating incoming dates against permitted date formats. Need to add ISO 8601-based patterns corresponding to those permitted by Nuxeo, determine how best to identify date fields whose values might be validated, and identify where during incoming payload handling to convert from non-ISO 8601 formats.
Aron Roberts [Mon, 16 Aug 2010 20:21:19 +0000 (20:21 +0000)]
CSPACE-2479: CollectionObject service now returns authority references from objectProductionPerson and objectProductionOrganization fields. (This work will need to be revisited when those two fields become part of repeatable groups; test cases added in this check-in will help ensure we make the necessary changes at that time to continue to pull authrefs from those fields.)
Aron Roberts [Fri, 13 Aug 2010 23:58:42 +0000 (23:58 +0000)]
CSPACE-827,CSPACE-2643: Added dimensions as a structured repeatable group of fields to CollectionObject records. Updated client tests to verify update behavior for dimensions groups, as described in the Common Services REST API documentation. Left six existing scalar dimensions fields in place for backwards compatibility, until dimensions are implemented as a repeatable group across all layers. Updates Nuxeo doctype definition, and thus requires 'ant deploy' from services/trunk and a 2-server restart.
Richard Millet [Thu, 12 Aug 2010 05:19:21 +0000 (05:19 +0000)]
CSPACE-2587: Add a separate log file for service profiling information. Also adding Laramie's filter class that we're using to profile requests to the service layer.
Aron Roberts [Thu, 12 Aug 2010 00:18:21 +0000 (00:18 +0000)]
CSPACE-2628: Fixed issue where the Movemement service was returning empty values in three dateTime fields. Removing the premature encoding of a calendar object to an ISO8601 string in MovementDocumentModelHandler.extractPart() resolved this issue. dateTime values are correctly encoded as ISO 8601 strings in the UTC time zone when a response document is being built, without any intervention required. Added client tests for this behavior.
Aron Roberts [Wed, 11 Aug 2010 19:22:22 +0000 (19:22 +0000)]
CSPACE-2578: Re-enabled test for XML parsing bug, where whitespace (and presumably any text) between the container element of a repeatable group and its first child prevented record creation. After the XML parsing-related improvements in CSPACE-2622, this issue appears to have been resolved, and this test now passes.
Aron Roberts [Wed, 11 Aug 2010 01:51:29 +0000 (01:51 +0000)]
CSPACE-2622: Trivial removal of several auto-generated Javadoc method comments, in favor of human-created comments which hadn't been propertly identified as Javadoc comments.
Aron Roberts [Mon, 9 Aug 2010 23:53:51 +0000 (23:53 +0000)]
CSPACE-2607: Commented out CollectionObjectResource.getIntakesCommonList(), which makes a call to getRelationList() in the relation service using a now-obsolete set of method parameters.
Aron Roberts [Mon, 9 Aug 2010 22:48:40 +0000 (22:48 +0000)]
CSPACE-2602: Checking in Laramie's changes to the deploy_jpa target in the common module's Ant buildfile. This resolves an issue, present in releases 0.7 and 0.8, which could result in a 'could not find resource file' error when running 'ant deploy'.
Aron Roberts [Mon, 9 Aug 2010 21:12:55 +0000 (21:12 +0000)]
CSPACE-2600: Checking in Laramie's set of changes to three files, to re-enable the 'query' module in the services source code tree. This module, while currently little used, will be instrumental for advanced search when that functionality is added to the services layer.
Aron Roberts [Mon, 9 Aug 2010 20:02:16 +0000 (20:02 +0000)]
CSPACE-2601: Checking in Laramie's set of changes to ten files - nearly all in sdk, sample, and import modules, which are built under a separate Maven profile - to reflect changes to object records that made object name fields repeatable as a group.
Aron Roberts [Mon, 9 Aug 2010 20:01:06 +0000 (20:01 +0000)]
CSPACE-2601: Checking in Laramie's set of changes to ten files - nearly all in sdk, sample, and import modules, which are built under a separate Maven profile - to reflect changes to object records that made object name fields repeatable as a group.
Aron Roberts [Fri, 6 Aug 2010 00:30:15 +0000 (00:30 +0000)]
CSPACE-2586: Retrieving referencing objects now works for repeatable, single scalar fields. (More specifically, this works when a referenced term is found in any value instance of a repeatable, single scalar field.) Apparently, this may not have previously worked but was missed by services client tests, and emerged only when implementing repeatable groups of fields.
Aron Roberts [Thu, 5 Aug 2010 19:26:27 +0000 (19:26 +0000)]
CSPACE-2577: Lists of referencing objects / refObjs now once again successfully returned. Fix involved commenting out one authRef field property in tenant bindings; that field, which is in a newly-introduced repeatable group of fields in Acquisition records, was causing Nuxeo's searches to fail. Also observed that we may not be currently testing for retrieving refObjs where the references occur in single scalar fields; will add JIRAs for both relevant issues.
Aron Roberts [Wed, 4 Aug 2010 22:41:49 +0000 (22:41 +0000)]
CSPACE-2578: Added client tests to demonstrate payload parsing issue where whitespace (or presumably any text node) is present between the container tag and the first child tag in a repeatable group of fields. Failing test is commented out so as not to break services tests, but can be uncommented during investigation of this issue.
Aron Roberts [Wed, 4 Aug 2010 05:31:33 +0000 (05:31 +0000)]
CSPACE-2469,CSPACE-2576,CSPACE-2577: Modified Acquisition records in the services layer, making the Acquisition Funding group repeatable. Modified document framework code to return authority references from individual value instances of fields in repeatable groups of fields. This work has temporarily broken retrieval of referenced documents associated with a term / authority reference, per newly-filed bug CSPACE-2577.
Aron Roberts [Mon, 2 Aug 2010 19:58:24 +0000 (19:58 +0000)]
CSPACE-2558: sourceField values in authority reference lists from services once again are qualified by schema names; e.g. 'acquisitions_common:acquisitionSource'. This was a regression bug caught by Chris. Will create a JIRA to add client tests of sourceField values, to help avoid such issues in the future.
Aron Roberts [Sat, 31 Jul 2010 00:31:27 +0000 (00:31 +0000)]
CSPACE-2572: Client test of sorting of Movement record by string or date type fields now exclude null values when performing comparisons, to avoid triggering Exceptions in Collator and Comparator classes.
Aron Roberts [Fri, 30 Jul 2010 23:48:30 +0000 (23:48 +0000)]
CSPACE-2558,CSPACE-2556: When returning lists of authority references (terms used) within a record, the sourceField name is once again correct for value instances of singly repeatable fields, rather than reflecting the parent field's name. This check-in assumes one level of repeatability (a parent field with 0-n child fields of the same name and type) and will require revision for complex, or nested, repeatability, but also lays the groundwork for such support.
Richard Millet [Fri, 30 Jul 2010 05:37:39 +0000 (05:37 +0000)]
CSPACE-2492, CSPACE-2492, CSPACE-2492, CSPACE-2463: Changes to reduce the number of permission/resource tuples -in hopes of simplifying the App->Service interactions. Also contains changes to Relation service to add support for query params for subject=sbj, predicate=prd, object=obj -this replaces paths like /subject, /type, /object.
Aron Roberts [Thu, 29 Jul 2010 22:00:53 +0000 (22:00 +0000)]
CSPACE-2559: Summary lists of Acquisition records, returned by the Acquisitions service, now once again correctly return values, in the value instances of the repeatable acquisitionSource field. This was a regression bug triggered by the removal of field qualification (prefixing by a field name and delimiter) in r2707, as well as my use of a private unqualify() method in the Acquisition service.
Aron Roberts [Wed, 28 Jul 2010 23:12:00 +0000 (23:12 +0000)]
CSPACE-2501,CSPACE-2451: Added multiple new fields to the CollectionObject schema for 1.0 alpha, as well as making several of the new fields, and several existing fields, singly repeatable. Also changed names for many fields, either to work around length limits for generated foreign key identifier names, or for consistency and clarity.
Aron Roberts [Sat, 24 Jul 2010 00:49:12 +0000 (00:49 +0000)]
CSPACE-2529,CSPACE-2549: Multiple changes to Intake records schema, in the services layer: added six new fields (three of them repeatable), and made five existing fields repeatable. Changes the relevant Nuxeo document type schema, and as such requires an 'ant deploy' and a 2-server restart.
Aron Roberts [Fri, 23 Jul 2010 22:42:02 +0000 (22:42 +0000)]
CSPACE-2535: Made five fields repeatable in Organization records (records of items within an OrgAuthority), in the services layer: contactName, group, function, subBody, and historyNote (formerly history). Changes the relevant Nuxeo document type schema, and as such requires an 'ant deploy' and a 2-server restart.
Aron Roberts [Fri, 23 Jul 2010 22:19:15 +0000 (22:19 +0000)]
CSPACE-2534: Temporarily comment out Nuxeo layout widgets for repeatable fields in Person records until we identify how to represent these complexTypes in layouts.
Aron Roberts [Fri, 23 Jul 2010 00:10:29 +0000 (00:10 +0000)]
CSPACE-2534: Made four fields repeatable in Person records (records of items within a PersonAuthority), in the services layer: group, nationality, occupation, and schoolOrStyle. Changes the relevant Nuxeo document type schema, and as such requires an 'ant deploy' and a 2-server restart.
Aron Roberts [Thu, 22 Jul 2010 22:06:47 +0000 (22:06 +0000)]
CSPACE-2528: Made acquisitionDate field a repeatable field in Acquisition records, in the services layer. Changes the relevant Nuxeo document type schema, and as such requires an 'ant deploy' and a 2-server restart.
Aron Roberts [Wed, 21 Jul 2010 02:31:55 +0000 (02:31 +0000)]
CSPACE-2511,CSPACE-2512: Standardized error messages returned from resource classes for Acquisitions, Movements, as prototype for other resource classes.
Patrick Schmitz [Tue, 20 Jul 2010 23:48:53 +0000 (23:48 +0000)]
CSPACE-864 Added support to handle deeply nested repeatable structures on the way out. Still need to rewrite the code to handle same on the way in. This code may need to be refactored into a Nuxeo-specific class, for consistency.
Aron Roberts [Tue, 20 Jul 2010 22:48:36 +0000 (22:48 +0000)]
CSPACE-2508: Explicitly tests sorting of results from keyword searches. Lays groundwork for restricting the scope of sorting tests to temporary records created during client testing.
Aron Roberts [Tue, 20 Jul 2010 20:53:30 +0000 (20:53 +0000)]
CSPACE-2508: Added client test to verify that records are returned in ascending or descending sort order, based on the value of a specified field, when a 'read list' or keyword search request asks that records be returned in that sort order.
Patrick Schmitz [Mon, 19 Jul 2010 06:46:28 +0000 (06:46 +0000)]
CSPACE-2394 Build a prototype reporting service for invoking reports. Still needs more build support to get reports installed from a resource path, but basic CRUDL support is in, as is invocation of jasper reports engine from services, provided a report has been installed on the server.
Patrick Schmitz [Fri, 16 Jul 2010 21:25:36 +0000 (21:25 +0000)]
NOJIRA - Fixed a bug in the processing of authority items when fetching by name - was not correctly qualifying by authority. Should allow shortIdentifier clash across (but not within) authorities, but was coughing on cross-authority clash. Typo in PersonAuthorityClient caused problems in test.
Aron Roberts [Thu, 15 Jul 2010 22:19:23 +0000 (22:19 +0000)]
CSPACE-1637,CSPACE-2066: Authority references can now be returned from value instances of repeatable fields, as well as - as was previously implemented - from non-repeatable fields. As prototyped in Acquisition records, specifying 'acquisitionSources' as an authRef field in tenant bindings will now return the authority references in each of its 'acquisitionSource' children. This has been tested to date only with simple repeatability: a parent and a set of 0-n immediate children. The current solution will need additional testing to verify that it works with arbitrary repeatability; and a slightly different approach using DocModel.getProperties(), as suggested by Richard and mentioned as well in code comments, may potentially be needed in that case.
Aron Roberts [Thu, 15 Jul 2010 03:28:16 +0000 (03:28 +0000)]
CSPACE-2408,CSPACE-2482: DateTime fields in Movement record are now editable, in the relevant layout for Nuxeo's web administration console, via a datetime picker widget.
Aron Roberts [Wed, 14 Jul 2010 03:49:37 +0000 (03:49 +0000)]
CSPACE-2408,CSPACE-2418: Changed datatypes for three calendar date fields in Movement records to xs:dateTime, to prototype storage of dates as date types, rather than strings. Provides a uniform date and time representation - a widely used ISO 8601 format - to be provided by clients as values in calendar date fields, as early work on CSPACE-2418. Dates round-trip correctly, but are stored in MySQL in a local time zone, rather than in UTC. This is potentially problematic, and may require further investigation. Two utility classes included in this commit likely belong in 'common' package, or in a future DateAndTime service, rather than in Movement, and they - or similar classes - will likely be migrated there in a future check-in.
Aron Roberts [Fri, 9 Jul 2010 00:35:50 +0000 (00:35 +0000)]
CSPACE-2408: Client tests of the Movement service now generate UTC timestamps, in preparation for the possibility of storing timestamps in the Location Date field (or an equivalent Movement Date field).
Aron Roberts [Thu, 8 Jul 2010 03:48:42 +0000 (03:48 +0000)]
CSPACE-1692,CSPACE-2330: CollectionObject service now returns authority references for all current authref fields (6 PersonAuthority fields and 3 OrgAuthority fields).
Patrick Schmitz [Tue, 6 Jul 2010 15:56:46 +0000 (15:56 +0000)]
CSPACE-749, CSPACE-1643, etc. Added keyword search support to vocab and authorities. Added test for same to Person service. Modified the query builder to put the keyword search where clause into parens so this can be safely combined with other searches (like matching the inAuthority).
Patrick Schmitz [Sat, 3 Jul 2010 19:24:50 +0000 (19:24 +0000)]
NOJIRA - Ported Authority cleanup to Location. This also addresses a number of missing elements in Location, around authRefs, named access, etc. Also cleaned up some inconsistent naming on the field that tracks term status, across all the authorities. Finally, added in more checks in test code across the authorities to ensure that ClientResponse instances are cleanly released.
Patrick Schmitz [Sat, 3 Jul 2010 04:35:22 +0000 (04:35 +0000)]
NOJIRA - Refactored autorities support. Fixed several inconsistencies, and simplified the code. Still some more to do to port this to Location, and to make authRefs and refObjs support more consistent.
Patrick Schmitz [Tue, 29 Jun 2010 16:33:18 +0000 (16:33 +0000)]
CSPACE-600, preparation for CSPACE-849, and fixed CSPACE-2291. This refactors the bulk of the vocabulary doc handlers into a superclass. Will port these changes to Person, Org, and Location, to simplify the maintenance of these services. Also aligns vocabulary to the other Authority services, to provide a more consistent API.
Aron Roberts [Fri, 25 Jun 2010 18:20:35 +0000 (18:20 +0000)]
CSPACE-2242: Created client tests to demonstrate bug, identified by Chris, in which value instances of a repeatable single String scalar field are not persisted if the first value instance is blank. (Note that the failing Assert is currently commented out in this check-in to avoid triggering service test failures.)