From: Aron Roberts <aron@socrates.berkeley.edu>
Date: Wed, 5 Dec 2012 22:29:08 +0000 (-0800)
Subject: CSPACE-5498: Tweaks to comments and log statements.
X-Git-Url: https://git.aero2k.de/?a=commitdiff_plain;h=7ce6e1c1059547e3c6d6dcddcb67423923b54f0e;p=tmp%2Fjakarta-migration.git

CSPACE-5498: Tweaks to comments and log statements.
---

diff --git a/3rdparty/nuxeo/nuxeo-platform-listener/updaterelationsondelete/src/main/java/org/collectionspace/services/listener/UpdateRelationsOnDelete.java b/3rdparty/nuxeo/nuxeo-platform-listener/updaterelationsondelete/src/main/java/org/collectionspace/services/listener/UpdateRelationsOnDelete.java
index b47f5ef4b..fbcb55c9d 100644
--- a/3rdparty/nuxeo/nuxeo-platform-listener/updaterelationsondelete/src/main/java/org/collectionspace/services/listener/UpdateRelationsOnDelete.java
+++ b/3rdparty/nuxeo/nuxeo-platform-listener/updaterelationsondelete/src/main/java/org/collectionspace/services/listener/UpdateRelationsOnDelete.java
@@ -1,8 +1,8 @@
 package org.collectionspace.services.listener;
 
 import java.util.ArrayList;
-import java.util.List;
 import java.util.IllegalFormatException;
+import java.util.List;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.collectionspace.services.client.workflow.WorkflowClient;
@@ -28,12 +28,14 @@ public class UpdateRelationsOnDelete implements EventListener {
 
     @Override
     public void handleEvent(Event event) throws ClientException {
-        logger.info("In handleEvent in UpdateRelationsOnDelete ...");
+        logger.trace("In handleEvent in UpdateRelationsOnDelete ...");
         
         EventContext eventContext = event.getContext();
 
         if (isDocumentSoftDeletedEvent(eventContext)) {
             
+            logger.trace("A soft deletion event was received by UpdateRelationsOnDelete ...");
+            
             DocumentEventContext docContext = (DocumentEventContext) eventContext;
             DocumentModel docModel = docContext.getSourceDocument();
             
@@ -52,6 +54,7 @@ public class UpdateRelationsOnDelete implements EventListener {
                 logger.trace("Query string=" + queryString);
             } catch (IllegalFormatException ife) {
                 logger.warn("Construction of formatted query string failed: ", ife);
+                logger.warn("Actions in this event listener will NOT be performed, as a result of a previous Exception.");
                 return;
             }
             
@@ -75,7 +78,7 @@ public class UpdateRelationsOnDelete implements EventListener {
             }
 
             // Cycle through the list results, soft deleting each matching relation record
-            logger.trace("Attempting to soft delete " + matchingDocuments.size() + " relation records.");
+            logger.info("Attempting to soft delete " + matchingDocuments.size() + " relation records pertaining to a soft deleted record.");
             for (DocumentModel doc : matchingDocuments) {
                 doc.followTransition(WorkflowClient.WORKFLOWTRANSITION_DELETE);
             }
@@ -83,6 +86,9 @@ public class UpdateRelationsOnDelete implements EventListener {
         }
 
     }
+    
+    // FIXME: Generic methods like the following might be split off
+    // into an event utilities class. - ADR 2012-12-05
 
     /**
      * Identifies whether a supplied event concerns a document that has
@@ -103,4 +109,5 @@ public class UpdateRelationsOnDelete implements EventListener {
         }
         return isSoftDeletedEvent;
     }
+    
 }