From: Aron Roberts <aron@socrates.berkeley.edu>
Date: Tue, 8 May 2012 21:32:26 +0000 (-0700)
Subject: CSPACE-4813,CSPACE-3178: Added comment to authority item doc model handler, with... 
X-Git-Url: https://git.aero2k.de/?a=commitdiff_plain;h=6ee9236edf87aae028d3bebb0caee24a7f7501d9;p=tmp%2Fjakarta-migration.git

CSPACE-4813,CSPACE-3178: Added comment to authority item doc model handler, with a query about whether to add back synthesizing the shortIdentifier from the displayName, in this case from the termDisplayName of the preferred term for the item.
---

diff --git a/services/authority/service/src/main/java/org/collectionspace/services/common/vocabulary/nuxeo/AuthorityItemDocumentModelHandler.java b/services/authority/service/src/main/java/org/collectionspace/services/common/vocabulary/nuxeo/AuthorityItemDocumentModelHandler.java
index c480dd53b..a82daf2ec 100644
--- a/services/authority/service/src/main/java/org/collectionspace/services/common/vocabulary/nuxeo/AuthorityItemDocumentModelHandler.java
+++ b/services/authority/service/src/main/java/org/collectionspace/services/common/vocabulary/nuxeo/AuthorityItemDocumentModelHandler.java
@@ -233,6 +233,12 @@ public abstract class AuthorityItemDocumentModelHandler<AICommon>
         // Ensure we have required fields set properly
         handleInAuthority(wrapDoc.getWrappedObject());
         
+        // FIXME: This call to synthesize a shortIdentifier from the termDisplayName
+        // of the preferred term may have been commented out, in the course of
+        // adding support for preferred / non-preferred terms, in CSPACE-4813
+        // and linked issues. Revisit this to determine whether we want to
+        // re-enable it.
+        //
         // CSPACE-3178:
         // handleDisplayNameAsShortIdentifier(wrapDoc.getWrappedObject(), authorityItemCommonSchemaName);
         // refName includes displayName, so we force a correct value here.