From: Ray Lee <ray.lee@lyrasis.org>
Date: Tue, 31 Mar 2020 16:58:01 +0000 (-0400)
Subject: Revert "DRYD-835: Stop on error when running upgrade scripts."
X-Git-Url: https://git.aero2k.de/?a=commitdiff_plain;h=26850f6dae4b310ddabeb7c042f6a1c54a87d847;p=tmp%2Fjakarta-migration.git

Revert "DRYD-835: Stop on error when running upgrade scripts."

This reverts commit 5a9cdffed9acf843acdcbedda3f47cba4ee675e3.
---

diff --git a/services/common/src/main/java/org/collectionspace/services/common/ServiceMain.java b/services/common/src/main/java/org/collectionspace/services/common/ServiceMain.java
index 77776f2a8..27b3aab8b 100644
--- a/services/common/src/main/java/org/collectionspace/services/common/ServiceMain.java
+++ b/services/common/src/main/java/org/collectionspace/services/common/ServiceMain.java
@@ -505,9 +505,6 @@ public class ServiceMain {
 			conn.commit();
 		}
 		catch (Exception e) {
-			logger.error(String.format("Could not upgrade %s repository", repositoryName));
-			logger.error(e.toString());
-
 			if (conn != null) {
 				conn.rollback();
 			}
diff --git a/services/common/src/main/java/org/collectionspace/services/common/storage/JDBCTools.java b/services/common/src/main/java/org/collectionspace/services/common/storage/JDBCTools.java
index a6bbb646b..ba715cf52 100644
--- a/services/common/src/main/java/org/collectionspace/services/common/storage/JDBCTools.java
+++ b/services/common/src/main/java/org/collectionspace/services/common/storage/JDBCTools.java
@@ -17,11 +17,15 @@
  */
 package org.collectionspace.services.common.storage;
 
+import org.collectionspace.services.common.ServiceMain;
+import org.collectionspace.services.common.api.JEEServerDeployment;
 import org.collectionspace.services.common.api.Tools;
 import org.collectionspace.services.common.config.ConfigUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java_cup.version;
+
 import javax.naming.Context;
 import javax.naming.InitialContext;
 import javax.naming.NamingException;
@@ -41,8 +45,14 @@ import java.sql.ResultSetMetaData;
 import java.sql.SQLException;
 import java.sql.Statement;
 import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Comparator;
 import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.regex.Pattern;
 
 import javax.sql.rowset.CachedRowSet;
 import javax.sql.rowset.RowSetFactory;
@@ -823,10 +833,8 @@ public class JDBCTools {
 
     public static void runScript(Connection conn, File scriptFile) throws FileNotFoundException {
         ScriptRunner scriptRunner = new ScriptRunner(conn);
+        Reader reader = new BufferedReader(new FileReader(scriptFile));
 
-        scriptRunner.setAutoCommit(false);
-        scriptRunner.setStopOnError(true);
-
-        scriptRunner.runScript(new BufferedReader(new FileReader(scriptFile)));
+        scriptRunner.runScript(reader);
     }
 }