]> git.aero2k.de Git - tmp/jakarta-migration.git/commitdiff
CSPACE-5332: Substituted logger calls for System.out|err print statements in Imports...
authorAron Roberts <aron@socrates.berkeley.edu>
Tue, 10 Jul 2012 01:58:25 +0000 (18:58 -0700)
committerAron Roberts <aron@socrates.berkeley.edu>
Tue, 10 Jul 2012 01:58:25 +0000 (18:58 -0700)
services/imports/service/src/main/java/org/collectionspace/services/imports/ImportsResource.java
services/imports/service/src/main/java/org/collectionspace/services/imports/TemplateExpander.java
services/imports/service/src/main/java/org/collectionspace/services/imports/nuxeo/ImportCommand.java
services/imports/service/src/main/java/org/collectionspace/services/imports/nuxeo/LoggedXMLDirectoryReader.java

index 158efbbf275816df94c99c2c929382a9eeb62c99..57123b24cc6f3cbeda9fdd0c28ce375c4821bb64 100644 (file)
@@ -67,6 +67,8 @@ import java.io.FileNotFoundException;
 import java.io.InputStream;
 import java.util.List;
 import java.util.Map;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 // The modified Nuxeo ImportCommand from nuxeo's shell:
 
@@ -77,11 +79,12 @@ import java.util.Map;
 @Produces({ "application/xml" })
 @Consumes({ "application/xml" })
 public class ImportsResource extends AbstractCollectionSpaceResourceImpl<PoxPayloadIn, PoxPayloadOut> {
+    
+        private final static Logger logger = LoggerFactory.getLogger(TemplateExpander.class);
 
        public static final String SERVICE_NAME = "imports";
        public static final String SERVICE_PATH = "/" + SERVICE_NAME;
        private static final int DEFAULT_TX_TIMOUT = 600; // timeout period in
-                                                                                                               // seconds
 
        /*
         * ASSUMPTION: All Nuxeo services of a given tenancy store their stuff in
@@ -285,8 +288,10 @@ public class ImportsResource extends AbstractCollectionSpaceResourceImpl<PoxPayl
                }
                String requestFilename = requestFile.getCanonicalPath();
                InputSource inputSource = new InputSource(requestFilename);
-               System.out.println("############## REQUEST_FILENAME: "
+                if (logger.isTraceEnabled()) {
+                    logger.trace("############## REQUEST_FILENAME: "
                                + requestFilename);
+                }
                return inputSource;
        }
 
@@ -302,8 +307,10 @@ public class ImportsResource extends AbstractCollectionSpaceResourceImpl<PoxPayl
                                        "Could not create file in requestDir: " + requestDir);
                }
                String requestFilename = requestFile.getCanonicalPath();
-               System.out.println("############## REQUEST_FILENAME: "
+                if (logger.isTraceEnabled()) {
+                   logger.trace("############## REQUEST_FILENAME: "
                                + requestFilename);
+                }
                return requestFilename;
        }
 
@@ -333,8 +340,10 @@ public class ImportsResource extends AbstractCollectionSpaceResourceImpl<PoxPayl
        public static void expandXmlPayloadToDir(String tenantId,
                        String inputFilename, String templateDir, String outputDir)
                        throws Exception {
-               System.out.println("############## TEMPLATE_DIR: " + templateDir);
-               System.out.println("############## OUTPUT_DIR:" + outputDir);
+                if (logger.isTraceEnabled()) {
+                    logger.trace("############## TEMPLATE_DIR: " + templateDir);
+                    logger.trace("############## OUTPUT_DIR:" + outputDir);
+                }
                File file = new File(inputFilename);
                FileInputStream is = new FileInputStream(file);
                InputSource inputSource = new InputSource(is);
@@ -361,8 +370,10 @@ public class ImportsResource extends AbstractCollectionSpaceResourceImpl<PoxPayl
        public static void expandXmlPayloadToDir(String tenantId,
                        InputSource inputSource, String templateDir, String outputDir)
                        throws Exception {
-               System.out.println("############## TEMPLATE_DIR: " + templateDir);
-               System.out.println("############## OUTPUT_DIR:" + outputDir);
+                if (logger.isTraceEnabled()) {
+                    logger.trace("############## TEMPLATE_DIR: " + templateDir);
+                    logger.trace("############## OUTPUT_DIR:" + outputDir);
+                }
                TemplateExpander.expandInputSource(tenantId, templateDir, outputDir,
                                inputSource, "/imports/import");
                // TemplateExpander.expandInputSource(templateDir, outputDir,
@@ -384,14 +395,18 @@ public class ImportsResource extends AbstractCollectionSpaceResourceImpl<PoxPayl
                try {
                        InputStream fileStream = null;
                        String preamble = partFormData.getPreamble();
-                       System.out.println("Preamble type is:" + preamble);
+                        if (logger.isTraceEnabled()) {
+                            logger.trace("Preamble type is:" + preamble);
+                        }
                        Map<String, List<InputPart>> partsMap = partFormData
                                        .getFormDataMap();
                        List<InputPart> fileParts = partsMap.get("file");
                        int timeout = this.getTimeoutParam(ui);
                        for (InputPart part : fileParts) {
                                String mediaType = part.getMediaType().toString();
-                               System.out.println("Media type is:" + mediaType);
+                                if (logger.isTraceEnabled()) {
+                                    logger.trace("Media type is:" + mediaType);
+                                }
                                if (mediaType.equalsIgnoreCase(MediaType.APPLICATION_XML)
                                                || mediaType.equalsIgnoreCase(MediaType.TEXT_XML)) {
                                        // FIXME For an alternate approach, potentially preferable,
@@ -419,19 +434,22 @@ public class ImportsResource extends AbstractCollectionSpaceResourceImpl<PoxPayl
                                        File zipfile = FileUtils.createTmpFile(fileStream,
                                                        getServiceName() + "_");
                                        String zipfileName = zipfile.getCanonicalPath();
-                                       System.out.println("Imports zip file saved to:"
-                                                       + zipfileName);
+                                        if (logger.isTraceEnabled()) {
+                                            logger.trace("Imports zip file saved to:"
+                                                            + zipfileName);
+                                        }
 
                                        String baseOutputDir = FileTools.createTmpDir("imports-")
                                                        .getCanonicalPath();
                                        File indir = new File(baseOutputDir + "/in");
                                        indir.mkdir();
                                        ZipTools.unzip(zipfileName, indir.getCanonicalPath());
-                                       String result = "\r\n<zipResult>Zipfile " + zipfileName
-                                                       + "extracted to: " + indir.getCanonicalPath()
-                                                       + "</zipResult>";
-                                       System.out.println(result);
-
+                                        String result = "\r\n<zipResult>Zipfile " + zipfileName
+                                                + "extracted to: " + indir.getCanonicalPath()
+                                                + "</zipResult>";
+                                        if (logger.isTraceEnabled()) {
+                                            logger.trace(result);
+                                        }
                                        long start = System.currentTimeMillis();
                                        // TODO: now call import service...
                                        resultBuf.append(result);
@@ -463,7 +481,9 @@ public class ImportsResource extends AbstractCollectionSpaceResourceImpl<PoxPayl
                        + "      <input name='file' type='file' accept='application/xml,text/xml' />\n"
                        + "      <br />\n"
                        + "      <input type='submit' value='Upload File' />\n"
-                       + "    </form>\n" + "  </body>\n" + "</html>\n";
+                       + "    </form>\n"
+                        + "  </body>\n"
+                        + "</html>\n";
 
        @GET
        @Produces("text/html")
index 5a1fe593041a9ab270093a1dda0958913e4b3193..e7c10a054b0a88f05c4b0d03d1abb21bcb2227f6 100644 (file)
@@ -47,6 +47,8 @@ import org.collectionspace.services.nuxeo.util.NuxeoUtils;
 import org.dom4j.Attribute;
 import org.dom4j.Document;
 import org.dom4j.Element;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.xml.sax.InputSource;
 
 /** This class expands variables in templates specifically for the imports service.
@@ -59,6 +61,8 @@ import org.xml.sax.InputSource;
  */
 public class TemplateExpander {
     
+    private final static Logger logger = LoggerFactory.getLogger(TemplateExpander.class);
+    
     private static final String DEFAULT_WRAPPER_TEMPLATE_FILENAME = "service-document.xml";
     private static Map<String,String> docTypeSvcNameRegistry = new HashMap<String,String>();
     private static XPath xpath = XPathFactory.newInstance().newXPath();
@@ -318,7 +322,7 @@ public class TemplateExpander {
             InputSource input = new InputSource(new StringReader(xmlFragmentWrapped));
             value = xpath.evaluate(xpathExpr, input);
         } catch (XPathExpressionException e) {
-            System.out.println(e.getMessage());
+            logger.error(e.getMessage());
         }
         return value;
 
@@ -357,12 +361,14 @@ public class TemplateExpander {
                 TemplateExpander.createDocInWorkspace(TENANT_ID, fragment, serviceName, serviceType,
                         perRecordAttributes, TEMPLATE_DIR, OUPUT_DIR, CSID);
             } catch (Exception e){
-                System.err.println("ERROR calling expandXmlPayloadToDir"+e);
+                logger.error("ERROR calling expandXmlPayloadToDir"+e);
                 e.printStackTrace();
             }
         }
         public void onEndDocument(Document document, int fragmentCount){
-            System.out.println("====TemplateExpander DONE============\r\n"+ XmlTools.prettyPrint(document)+"================");
+            if (logger.isTraceEnabled()) {
+                logger.trace("====TemplateExpander DONE============\r\n"+ XmlTools.prettyPrint(document)+"================");
+            }
         }
         
         //============helper methods==============================================================
@@ -390,9 +396,11 @@ public class TemplateExpander {
         }
         
         private void dump(Document context, String currentPath, int fragmentIndex, String fragment){
-            System.out.println("====Path============\r\n"+currentPath+'['+fragmentIndex+']');
-            System.out.println("====Context=========\r\n"+ XmlTools.prettyPrint(context));
-            System.out.println("====Fragment========\r\n"+fragment+"\r\n===================\r\n");
+            if (logger.isTraceEnabled()) {
+                logger.trace("====Path============\r\n"+currentPath+'['+fragmentIndex+']');
+                logger.trace("====Context=========\r\n"+ XmlTools.prettyPrint(context));
+                logger.trace("====Fragment========\r\n"+fragment+"\r\n===================\r\n");
+            }
         }
     }
 
index 29abf6f0c4303cb5881b6dba12e0e947602d29d4..e6aeb2fa5a7aebeae084acf24f7f07dbf41478be 100644 (file)
@@ -5,8 +5,6 @@ import java.util.Calendar;
 import java.util.HashMap;\r
 import java.util.Map;\r
 import java.util.TreeSet;\r
-import org.apache.commons.logging.Log;\r
-import org.apache.commons.logging.LogFactory;\r
 import org.collectionspace.services.nuxeo.client.java.NuxeoClientEmbedded;\r
 import org.collectionspace.services.nuxeo.client.java.NuxeoConnectorEmbedded;\r
 import org.nuxeo.ecm.core.api.DocumentModel;\r
@@ -19,10 +17,13 @@ import org.nuxeo.ecm.core.io.DocumentWriter;
 import org.nuxeo.ecm.core.io.impl.DocumentPipeImpl;\r
 import org.nuxeo.ecm.core.io.impl.plugins.DocumentModelWriter;\r
 // we use our own override of this: import org.nuxeo.ecm.core.io.impl.plugins.XMLDirectoryReader;\r
+import org.slf4j.Logger;\r
+import org.slf4j.LoggerFactory;\r
 \r
 // based loosely on package org.nuxeo.ecm.shell.commands.io.ImportCommand;\r
 public class ImportCommand {\r
-    private static final Log logger = LogFactory.getLog(ImportCommand.class);\r
+    \r
+    private final Logger logger = LoggerFactory.getLogger(ImportCommand.class);\r
 \r
     public String run(String src, String dest, int timeOut) throws Exception {\r
         File file = new File(src);\r
@@ -30,16 +31,18 @@ public class ImportCommand {
         NuxeoClientEmbedded client = NuxeoConnectorEmbedded.getInstance().getClient();\r
         RepositoryInstance  repoSession = client.openRepository(timeOut);\r
         try {\r
-               String msg = String.format("Start of import is Local time: %tT", Calendar.getInstance());\r
-               logger.debug(msg);\r
-               System.out.println(msg);\r
+            if (logger.isDebugEnabled()) {\r
+                String msg = String.format("Start of import is Local time: %tT", Calendar.getInstance());\r
+                logger.debug(msg);\r
+            }\r
             return importTree(repoSession, file, dest);\r
         } catch (Exception e) {\r
             throw e;\r
         } finally {\r
+            if (logger.isDebugEnabled()) {\r
                String msg = String.format("End of import is Local time: %tT", Calendar.getInstance());\r
                logger.debug(msg);\r
-               System.out.println(msg);\r
+            }\r
             client.releaseRepository(repoSession);\r
         }\r
     }\r
@@ -56,7 +59,9 @@ public class ImportCommand {
         Integer numRecordsImportedForDocType = new Integer(0);\r
         int totalRecordsImported = 0;\r
         try {\r
-            System.out.println("importTree reading file: "+file+(file!=null ? " exists? "+file.exists() : " file param is null"));\r
+            if (logger.isInfoEnabled()) {\r
+                logger.info("importTree reading file: "+file+(file!=null ? " exists? "+file.exists() : " file param is null"));\r
+            }\r
             reader = new LoggedXMLDirectoryReader(file);  //our overload of XMLDirectoryReader.\r
             writer = new DocumentModelWriter(repoSession, toPath, 10);\r
             DocumentPipe pipe = new DocumentPipeImpl(10);\r
@@ -115,7 +120,6 @@ public class ImportCommand {
             if (failed != null) {\r
                String msg = "The Import service encountered an exception: " + failed.getLocalizedMessage();\r
                logger.error(msg, failed);\r
-               System.err.println(msg);\r
             }\r
         }\r
         return dump.toString();\r
index 6d2ed5713e2112d81fb385bf42e0beafe4121521..fc5be016c094f5535a5281eff203678bd0a11156 100644 (file)
@@ -7,7 +7,6 @@ import java.io.FileInputStream;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
-
 import org.dom4j.Document;
 import org.dom4j.DocumentException;
 import org.dom4j.io.SAXReader;
@@ -20,23 +19,33 @@ import org.nuxeo.ecm.core.io.ExportedDocument;
 import org.nuxeo.ecm.core.io.impl.AbstractDocumentReader;
 import org.nuxeo.ecm.core.io.impl.ExportedDocumentImpl;
 import org.nuxeo.runtime.services.streaming.FileSource;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class LoggedXMLDirectoryReader extends AbstractDocumentReader {
+    
+    private final Logger logger = LoggerFactory.getLogger(LoggedXMLDirectoryReader.class);
+
 
     protected Document loadXML(File file) throws IOException {
         String filename = file.getCanonicalPath();
-        System.out.println("~~~~~~~~~~~~~~~~~~~ LoggedXMLDirectoryReader :: "+filename);
+        
+        if (logger.isTraceEnabled()) {
+            logger.trace("~~~~~~~~~~~~~~~~~~~ LoggedXMLDirectoryReader :: "+filename);
+        }
         BufferedInputStream in = null;
         try {
             in = new BufferedInputStream(new FileInputStream(file));
-            System.out.println("~~~~~~~~~~~~~~~~~~~ LoggedXMLDirectoryReader :: "+filename+" :: DONE");
+            if (logger.isTraceEnabled()) {
+                logger.trace("~~~~~~~~~~~~~~~~~~~ LoggedXMLDirectoryReader :: "+filename+" :: DONE");
+            }
             reportList.add("READ: "+filename);
             return new SAXReader().read(in);
         } catch (DocumentException e) {
             IOException ioe = new IOException("Failed to read file document "
                     + file + ": " + e.getMessage());
             ioe.setStackTrace(e.getStackTrace());
-            System.out.println("~~~~~~~~~~~~~~~~~~~ LoggedXMLDirectoryReader :: "+filename+" :: ERROR");
+            logger.error("~~~~~~~~~~~~~~~~~~~ LoggedXMLDirectoryReader :: "+filename+" :: ERROR");
             reportList.add("ERROR: "+filename);
             throw ioe;
         } finally {